[MNG-7758] Report dependency problems for all repository

apache · Jun 5, 2024 · 26695ff · 26695ff
1 parent 0456c7c
commit 26695ff
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 2 deletions.
diff --git a/maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java b/maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
@@ -160,7 +160,9 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request)
             result.setCollectionErrors(e.getResult().getExceptions());
 
             throw new DependencyResolutionException(
-                    result, "Could not resolve dependencies for project " + project.getId() + ": " + e.getMessage(), e);
+                    result,
+                    "Could not collect dependencies for project " + project.getId(),
+                    logger.isDebugEnabled() ? e : null);
         }
 
         depRequest.setRoot(node);
@@ -190,7 +192,9 @@ public DependencyResolutionResult resolve(DependencyResolutionRequest request)
             process(result, e.getResult().getArtifactResults());
 
             throw new DependencyResolutionException(
-                    result, "Could not resolve dependencies for project " + project.getId() + ": " + e.getMessage(), e);
+                    result,
+                    "Could not resolve dependencies for project " + project.getId(),
+                    logger.isDebugEnabled() ? e : null);
         }
 
         return result;

diff --git a/maven-core/src/main/java/org/apache/maven/project/DependencyResolutionException.java b/maven-core/src/main/java/org/apache/maven/project/DependencyResolutionException.java
@@ -18,18 +18,52 @@
  */
 package org.apache.maven.project;
 
+import java.util.List;
+
+import org.eclipse.aether.graph.Dependency;
+
 /**
  */
 public class DependencyResolutionException extends Exception {
 
     private final transient DependencyResolutionResult result;
+    private final transient String detailMessage;
 
     public DependencyResolutionException(DependencyResolutionResult result, String message, Throwable cause) {
         super(message, cause);
         this.result = result;
+        this.detailMessage = prepareDetailMessage(message, result);
+    }
+
+    private static String prepareDetailMessage(String message, DependencyResolutionResult result) {
+        StringBuilder msg = new StringBuilder(message);
+        msg.append(System.lineSeparator());
+        for (Dependency dependency : result.getUnresolvedDependencies()) {
+            msg.append("dependency: ").append(dependency).append(System.lineSeparator());
+            List<Exception> exceptions = result.getResolutionErrors(dependency);
+            for (Exception e : exceptions) {
+                msg.append("\t").append(e.getMessage()).append(System.lineSeparator());
+            }
+        }
+
+        for (Exception exception : result.getCollectionErrors()) {
+            msg.append(exception.getMessage()).append(System.lineSeparator());
+            if (exception.getCause() != null) {
+                msg.append("\tCaused by: ")
+                        .append(exception.getCause().getMessage())
+                        .append(System.lineSeparator());
+            }
+        }
+
+        return msg.toString();
     }
 
     public DependencyResolutionResult getResult() {
         return result;
     }
+
+    @Override
+    public String getMessage() {
+        return detailMessage;
+    }
 }