Clean usage of SessionData

apache · Apr 17, 2023 · 68b2330 · 68b2330
1 parent 432bd7a
commit 68b2330
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 22 deletions.
diff --git a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java b/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
@@ -274,16 +274,8 @@ public void close() {
         @SuppressWarnings({"unchecked", "rawtypes"})
         private OwnerReentrantLock getProjectLock(MavenSession session) {
             SessionData data = session.getRepositorySession().getData();
-            // TODO: when resolver 1.7.3 is released, the code below should be changed to
-            // TODO: Map<MavenProject, Lock> locks = ( Map ) ((Map) data).computeIfAbsent(
-            // TODO:         ProjectLock.class, l -> new ConcurrentHashMap<>() );
-            Map<MavenProject, OwnerReentrantLock> locks = (Map) data.get(ProjectLock.class);
-            // initialize the value if not already done (in case of a concurrent access) to the method
-            if (locks == null) {
-                // the call to data.set(k, null, v) is effectively a call to data.putIfAbsent(k, v)
-                data.set(ProjectLock.class, null, new ConcurrentHashMap<>());
-                locks = (Map) data.get(ProjectLock.class);
-            }
+            Map<MavenProject, OwnerReentrantLock> locks =
+                    (Map) data.computeIfAbsent(ProjectLock.class, ConcurrentHashMap::new);
             return locks.computeIfAbsent(session.getCurrentProject(), p -> new OwnerReentrantLock());
         }
     }

diff --git a/.../src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java b/.../src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java
@@ -100,8 +100,7 @@ public PluginVersionResult resolve(PluginVersionRequest request) throws PluginVe
         PluginVersionResult result = resolveFromProject(request);
 
         if (result == null) {
-            ConcurrentMap<Key, PluginVersionResult> cache =
-                    getCache(request.getRepositorySession().getData());
+            ConcurrentMap<Key, PluginVersionResult> cache = getCache(request);
             Key key = getKey(request);
             result = cache.get(key);
 
@@ -354,16 +353,10 @@ private PluginVersionResult resolveFromProject(PluginVersionRequest request, Lis
     }
 
     @SuppressWarnings("unchecked")
-    private ConcurrentMap<Key, PluginVersionResult> getCache(SessionData data) {
-        ConcurrentMap<Key, PluginVersionResult> cache = (ConcurrentMap<Key, PluginVersionResult>) data.get(CACHE_KEY);
-        while (cache == null) {
-            cache = new ConcurrentHashMap<>(256);
-            if (data.set(CACHE_KEY, null, cache)) {
-                break;
-            }
-            cache = (ConcurrentMap<Key, PluginVersionResult>) data.get(CACHE_KEY);
-        }
-        return cache;
+    private ConcurrentMap<Key, PluginVersionResult> getCache(PluginVersionRequest request) {
+        SessionData data = request.getRepositorySession().getData();
+        return (ConcurrentMap<Key, PluginVersionResult>)
+            data.computeIfAbsent(CACHE_KEY, () -> new ConcurrentHashMap<>(256));
     }
 
     private static Key getKey(PluginVersionRequest request) {