-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
As they really can come from anywhere. In case of this issue even from some eliminated POM that was read while collecting dirty tree, and was later eliminated. So confusing for users. --- https://issues.apache.org/jira/browse/MNG-8177
- Loading branch information
Showing
2 changed files
with
100 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
...olver-provider/src/main/java/org/apache/maven/repository/internal/RequestTraceHelper.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.maven.repository.internal; | ||
|
|
||
| import java.util.stream.Collectors; | ||
|
|
||
| import org.apache.maven.model.Plugin; | ||
| import org.eclipse.aether.RequestTrace; | ||
| import org.eclipse.aether.collection.CollectRequest; | ||
| import org.eclipse.aether.collection.CollectStepData; | ||
| import org.eclipse.aether.resolution.ArtifactDescriptorRequest; | ||
| import org.eclipse.aether.resolution.ArtifactRequest; | ||
| import org.eclipse.aether.resolution.DependencyRequest; | ||
|
|
||
| /** | ||
| * Helper class to manage {@link RequestTrace} for better error logging. | ||
| * | ||
| * @since 3.9.9 | ||
| */ | ||
| public final class RequestTraceHelper { | ||
|
|
||
| /** | ||
| * Method that creates some informational string based on passed in {@link RequestTrace}. The contents of request | ||
| * trace can literally be anything, but this class tries to cover "most common" cases that are happening in Maven. | ||
| */ | ||
| public static String interpretTrace(boolean detailed, RequestTrace requestTrace) { | ||
| while (requestTrace != null) { | ||
| Object data = requestTrace.getData(); | ||
| if (data instanceof DependencyRequest) { | ||
| DependencyRequest request = (DependencyRequest) data; | ||
| return "dependency resolution for " + request; | ||
| } else if (data instanceof CollectRequest) { | ||
| CollectRequest request = (CollectRequest) data; | ||
| return "dependency collection for " + request; | ||
| } else if (data instanceof CollectStepData) { | ||
| CollectStepData stepData = (CollectStepData) data; | ||
| String msg = "dependency collection step for " + stepData.getContext(); | ||
| if (detailed) { | ||
| msg += ". Path to offending node from root:\n"; | ||
| msg += stepData.getPath().stream() | ||
| .map(n -> " -> " + n.toString()) | ||
| .collect(Collectors.joining("\n")); | ||
| msg += "\n => " + stepData.getNode(); | ||
| } | ||
| return msg; | ||
| } else if (data instanceof ArtifactDescriptorRequest) { | ||
| ArtifactDescriptorRequest request = (ArtifactDescriptorRequest) data; | ||
| return "artifact descriptor request for " + request.getArtifact(); | ||
| } else if (data instanceof ArtifactRequest) { | ||
| ArtifactRequest request = (ArtifactRequest) data; | ||
| return "artifact request for " + request.getArtifact(); | ||
| } else if (data instanceof Plugin) { | ||
| Plugin plugin = (Plugin) data; | ||
| return "plugin request " + plugin.getId(); | ||
| } | ||
| requestTrace = requestTrace.getParent(); | ||
| } | ||
|
|
||
| return "n/a"; | ||
| } | ||
| } |