Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused code #1016

Merged
merged 1 commit into from
Feb 26, 2023
Merged

remove unused code #1016

merged 1 commit into from
Feb 26, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 26, 2023

and we remove reference to class we want to delete

@elharo elharo requested a review from gnodet February 26, 2023 15:17
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, the goal is to get rid of the org.codehaus.plexus classes in this artifact, see codehaus-plexus/plexus-utils#236 and the discussion on dev@

@elharo
Copy link
Contributor Author

elharo commented Feb 26, 2023

Yes, I've been looking at that. There are several somewhat parallel tracks here. The work you're doing on XML is the biggest part of it. I'd also like to get rid of a lot of the duplicate utility code that's been copied and pasted into Plexus utils, maven-shared-utils, apache commons, and other places over the years. These days a lot of it can ve found in the JDK. Ideally I'd like tp reach a point where org.codehaus is nowhere to be found in our code. One can dream. :-)

@elharo elharo merged commit 85ac42d into master Feb 26, 2023
@elharo elharo deleted the dom branch February 26, 2023 18:28
@gnodet
Copy link
Contributor

gnodet commented Feb 26, 2023

Yes, I've been looking at that. There are several somewhat parallel tracks here. The work you're doing on XML is the biggest part of it. I'd also like to get rid of a lot of the duplicate utility code that's been copied and pasted into Plexus utils, maven-shared-utils, apache commons, and other places over the years. These days a lot of it can ve found in the JDK. Ideally I'd like tp reach a point where org.codehaus is nowhere to be found in our code. One can dream. :-)

I would begin by removing any dependency on maven-shared-utils because I think not many projects have migrated from plexus-utils. So the path will be much easier in this way.

@elharo
Copy link
Contributor Author

elharo commented Feb 27, 2023

It all moves to JDK classes when possible, and Apache commons when not so there's no intermediate step. This is true whether it's maven-shared-utils or plexus utils. I have already deprecated a lot of the functionality in maven-shared-utils so I hope that pokes a few projects to update themselves without me having to do the work piecemeal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants