[MNG-7713] Make Maven fail if option present #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with previous PR (simple removal) the `-llr` got interpreted as `-l lr`, it logged all output to `lr` file. This would maean that use of `-llr` would still sneakily 'work' and probably cause surprise down the road to users. Returned the option, and expicitly checking for it's presence to be able to fail with meaningful message. --- https://issues.apache.org/jira/browse/MNG-7713
| @@ -280,6 +280,12 @@ public CLIManager() { | |||
| .desc("Ineffective, only kept for backward compatibility") | |||
| .build()); | |||
|
|
|||
| // Adding this back to make Maven fail if used | |||
There was a problem hiding this comment.
Please add info about conflict with -l lr - why we need it
There was a problem hiding this comment.
We need it not only to avoid conflicting -l lr but also to emit sane error message (so we really want to parse it from CLI but fail if present). So, I started a new "section" here (below the "ineffective section") for those that should fail.
slawekjaranowski
approved these changes
Mar 1, 2023
cstamas
added a commit
to cstamas/maven
that referenced
this pull request
Mar 1, 2023
As with previous PR (simple removal) the `-llr` got interpreted as `-l lr`, it logged all output to `lr` file. This would maean that use of `-llr` would still sneakily 'work' and probably cause surprise down the road to users. Returned the option, and expicitly checking for it's presence to be able to fail with meaningful message. --- https://issues.apache.org/jira/browse/MNG-7713
cstamas
added a commit
that referenced
this pull request
Mar 1, 2023
As with previous PR (simple removal) the `-llr` got interpreted as `-l lr`, it logged all output to `lr` file. This would maean that use of `-llr` would still sneakily 'work' and probably cause surprise down the road to users. Returned the option, and expicitly checking for it's presence to be able to fail with meaningful message. --- https://issues.apache.org/jira/browse/MNG-7713
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with previous PR (simple removal) the
-llrgot interpreted as-l lr, it logged all output tolrfile. This would maean that use of-llrwould still sneakily 'work' and probably cause surprise down the road to users.Returned the option, and expicitly checking for it's presence to be able to fail with meaningful message.
https://issues.apache.org/jira/browse/MNG-7713