[MNG-7724] don't warn about unsupported SLF4J configs; no one cares #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmannibucau
approved these changes
Mar 11, 2023
|
what if plugin use SLF4J 2 (not supported by Maven) - then we will just hide issue |
|
@slachiewicz not differently than today, keep in mind it was already not working since it was using the broken logger setup to log, only actual useful logging was the printstacktrace on stderr (without logger) when the integration was not working which can't happen here since this init is done before the init so tempted to say we support your case dropping the code ;). |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more direct approach to avoiding the warnings. Just take them out. They're not actionable and no one cares about this.