Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6825] Replace FileUtils with Commons IO #1067

Merged

Conversation

timtebeek
Copy link
Contributor

For: https://issues.apache.org/jira/browse/MNG-6825

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@timtebeek
Copy link
Contributor Author

This PR was largely created through: https://github.com/timtebeek/maven-rewrite/blob/main/file-utils.yml

It's not yet a complete migration, as a few cases need dedicated recipes, or manual work to convert completely, depending on how much they are used.

@elharo
Copy link
Contributor

elharo commented Mar 19, 2023

Failure looks flaky and unrelated:

Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (checkstyle-check) on project core-its: Execution checkstyle-check of goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check failed: Plugin org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven:maven-artifact:jar:3.0 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/maven-artifact/3.0/maven-artifact-3.0.jar: Connect to repo.maven.apache.org:443 [repo.maven.apache.org/146.75.28.215] failed: Connection timed out

@gnodet
Copy link
Contributor

gnodet commented Mar 19, 2023

Could we just switch to the nio api which provides a bunch of helper methods ? I'd rather remove dependencies than adding one....

@michael-o
Copy link
Member

Could we just switch to the nio api which provides a bunch of helper methods ? I'd rather remove dependencies than adding one....

I think yes, with a little bit of effort.

@elharo
Copy link
Contributor

elharo commented Mar 19, 2023

Not everything in this PR is covered by NIO in Java 8. As of Java 11 though we should be able to remove most uses of Apache Commons IO too.

@elharo elharo merged commit 703f814 into apache:master Mar 19, 2023
@timtebeek timtebeek deleted the refactor/replace-file-utils-with-commons-io branch March 19, 2023 20:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants