Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7714] Fixed a scenario in version sorting where sp1 is less than final #1099

Merged
merged 6 commits into from
Jun 21, 2023

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented May 2, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Signed-off-by: crazyhzm <crazyhzm@apache.org>
@CrazyHZM CrazyHZM changed the title Fixed a scenario in version sorting where sp1 is less than final [MNG-7714] Fixed a scenario in version sorting where sp1 is less than final May 2, 2023
Signed-off-by: crazyhzm <crazyhzm@apache.org>
Signed-off-by: crazyhzm <crazyhzm@apache.org>
Signed-off-by: crazyhzm <crazyhzm@apache.org>
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I do think there's still some work to make clearer what the intention of the tests is. Possibly we also need to expand the Javadoc on ComparableVersion to indicate this class is no longer consistent with equals.

Signed-off-by: crazyhzm <crazyhzm@apache.org>
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor optional comments on javadoc, but algorithm and test wise I think this is ready. Thanks!

Signed-off-by: crazyhzm <crazyhzm@apache.org>
@elharo elharo merged commit e3529c9 into apache:master Jun 21, 2023
18 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants