Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-7038] Fixes for topDirectory #1100

Merged
merged 1 commit into from
May 2, 2023
Merged

[MNG-7038] Fixes for topDirectory #1100

merged 1 commit into from
May 2, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented May 2, 2023

Changes:

  • resolve file argument against workingDirectory explicitly
  • the check Files.isRegularFile should happen against path

@cstamas
[MNG-7038] Fixes for topDirectory
cda0c77 
Changes:
* resolve file argument against workingDirectory explicitly
* the check Files.isRegularFile should happen against path
@cstamas cstamas requested a review from gnodet May 2, 2023 15:49
@cstamas cstamas self-assigned this May 2, 2023
@cstamas cstamas merged commit bec53b3 into apache:master May 2, 2023
@cstamas cstamas deleted the MNG-7038-fix-topDirectory branch May 2, 2023 18:38
@gnodet gnodet added this to the 4.0.0-alpha-6 milestone May 17, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet gnodet approved these changes

@michael-o michael-o Awaiting requested review from michael-o

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
4.0.0-alpha-7
Development

Successfully merging this pull request may close these issues.
2 participants
@cstamas @gnodet