Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-7604] Removal of pom.* interpolation makes some older plugins defunct #1137

Merged
merged 3 commits into from
Jun 5, 2023
Merged

[MNG-7604] Removal of pom.* interpolation makes some older plugins defunct #1137

merged 3 commits into from
Jun 5, 2023

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jun 1, 2023 •
edited
Loading

This reverts commit b2a21f1.

JIRA issue: https://issues.apache.org/jira/browse/MNG-7604

@gnodet gnodet added this to the 4.0.0-alpha-6 milestone Jun 1, 2023
mthmulders
mthmulders requested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@mthmulders mthmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this one. I had no idea how to solve it, but this seems like a nice approach.

This text in the PR body caught me off guard

This reverts commit b2a21f1.

If I understand correctly, this PR doesn't revert b2a21f1, but refines or enhances it by only performing the validation if it needs to.

Out of curiosity: how does Maven determine which validation level to apply?

maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingRequest.java Outdated Show resolved Hide resolved
@gnodet
Copy link
Contributor Author

gnodet commented Jun 1, 2023

Thanks for creating this one. I had no idea how to solve it, but this seems like a nice approach.

This text in the PR body caught me off guard

This reverts commit b2a21f1.

If I understand correctly, this PR doesn't revert b2a21f1, but refines or enhances it by only performing the validation if it needs to.

Right, my original idea was to do a two step thing ...

Out of curiosity: how does Maven determine which validation level to apply?

The default value is VALIDATION_LEVEL_STRICT. When reading poms which are external to the workspace, the code usually set the validation level on the ModelBuildingRequest to VALIDATION_LEVEL_MINIMAL, as done here. I don't think other values are actually used.

gnodet and others added 2 commits June 1, 2023 22:57
@gnodet
Fix javadoc
a5896d2
@gnodet @mthmulders
Update maven-model-builder/src/main/java/org/apache/maven/model/build…
c392d47 
…ing/ModelBuildingRequest.java

Co-authored-by: Maarten Mulders <mthmulders@users.noreply.github.com>
@mthmulders
Copy link
Contributor

Out of curiosity: how does Maven determine which validation level to apply?

The default value is VALIDATION_LEVEL_STRICT. When reading poms which are external to the workspace, the code usually set the validation level on the ModelBuildingRequest to VALIDATION_LEVEL_MINIMAL, as done here. I don't think other values are actually used.

Thanks for clarifying!

cstamas
cstamas approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change affects only master (and the preceding "removal" of interpolation as well)?

@gnodet
Copy link
Contributor Author

gnodet commented Jun 5, 2023

This change affects only master (and the preceding "removal" of interpolation as well)?

3.9 is not affected afaik, https://issues.apache.org/jira/browse/MNG-7244 was only targeted at 4.x

@gnodet gnodet merged commit ea1a280 into apache:master Jun 5, 2023
@gnodet gnodet deleted the MNG-7604-support-pom-props-from-central branch June 5, 2023 08:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas cstamas approved these changes

@mthmulders mthmulders mthmulders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-alpha-7
Development

Successfully merging this pull request may close these issues.
3 participants
@gnodet @mthmulders @cstamas