Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7806] Plugins verification - remove used in module(s) report #1151

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but today I'd maybe completely remove "used" thing. First, usually plugin is defined in parent and most usually is inherited by all child modules, and I agree, it is just a mess. IMHO, it is more important where plugin is defined (to make user go there and edit the POM)

@slawekjaranowski
Copy link
Member Author

LGTM, but today I'd maybe completely remove "used" thing. First, usually plugin is defined in parent and most usually is inherited by all child modules, and I agree, it is just a mess. IMHO, it is more important where plugin is defined (to make user go there and edit the POM)

Agree - so I will remove it at all.

@cstamas
Copy link
Member

cstamas commented Jun 11, 2023

Note: forward port to Maven4/master required, as currently validation is 1:1 in both (maven-3.9.x and master), JIRA adjusted as well.

@slawekjaranowski slawekjaranowski changed the title [MNG-7806] Plugins verification - limit the number of reported items by used in module(s) [MNG-7806] Plugins verification - remove used in module(s) report Jun 12, 2023
@cstamas cstamas added this to the 3.9.3 milestone Jun 13, 2023
@slawekjaranowski slawekjaranowski merged commit 3135553 into maven-3.9.x Jun 13, 2023
@slawekjaranowski slawekjaranowski deleted the MNG-7806 branch June 13, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants