[MNG-7814] Use location tracking for settings #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
approved these changes
Jun 16, 2023
cstamas
reviewed
Jun 16, 2023
api/maven-api-settings/src/main/java/org/apache/maven/api/settings/InputSource.java
Outdated
Show resolved
Hide resolved
cstamas
reviewed
Jun 16, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/browse/MNG-7814
The idea is to improve the settings xml parser, reusing the mechanism used to read models and keep track of locations even across merges. We just reuse the existing velocity templates
This opens the ability to do things like
mvn help:effective-settings -Dverbosewhich is currently not supported.