Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-7816] Bump parent pom from 39 to 40 #1170

Merged
merged 2 commits into from
Jun 16, 2023
Merged

[MNG-7816] Bump parent pom from 39 to 40 #1170

merged 2 commits into from
Jun 16, 2023

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jun 16, 2023

@gnodet gnodet added this to the 4.0.0-alpha-6 milestone Jun 16, 2023
slawekjaranowski
slawekjaranowski reviewed Jun 16, 2023
View reviewed changes
pom.xml
@@ -24,7 +24,7 @@ under the License.
<groupId>org.apache.maven</groupId>
<artifactId>maven-parent</artifactId>
<!-- please also update in maven-bom -->
<version>39</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and in maven-bom 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why don't we use the flatten plugin and inherit the parent ?

@gnodet gnodet merged commit c9f0c23 into apache:master Jun 16, 2023
18 checks passed
@gnodet gnodet deleted the parent-40 branch June 20, 2023 06:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas cstamas approved these changes

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-alpha-7
Development

Successfully merging this pull request may close these issues.
3 participants
@gnodet @cstamas @slawekjaranowski