[MNG-8176] Restrict classloader for Maven 4 plugins #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmannibucau
reviewed
Dec 7, 2023
gnodet
force-pushed
the
plugin-v4-classloader
branch
from
9955de3
to
ad1094e
Compare
gnodet
force-pushed
the
plugin-v4-classloader
branch
from
ad1094e
to
41cbe0c
Compare
gnodet
force-pushed
the
plugin-v4-classloader
branch
from
41cbe0c
to
a0f8397
Compare
gnodet
changed the title
rmannibucau
approved these changes
Aug 12, 2024
cstamas
approved these changes
Aug 12, 2024
The plan would be to allow some customization by the plugin later, so that they can add/remove packages and fine tune their class loader. In most cases, slf4j is not a problem. |
Well, from my perspective we decided to use maven.api logging api and let the mojo use or not another API/binding/solution so there is no more reason to let slf4j leak (or then we should let leak other stuff too). But just my 2 cts indeed. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.