[MNG-8005] Fix workspace reader drop bug #1385
Conversation
Maven4 seems sets but then drops/overrides some workspace readers. Partially due hazy borders who or what manages them, as role is split between session factory and session factory caller. Changes: * session factory does NOTHING re workspace readers, it becomes fully the caller duty * two spots calling (default maven, extension bootstrap) are now fully in charge to properly setup workspace readers --- https://issues.apache.org/jira/browse/MNG-8005
| } | ||
|
|
||
| public List<CoreExtensionEntry> loadCoreExtensions( | ||
| MavenExecutionRequest request, Set<String> providedArtifacts, List<CoreExtension> extensions) | ||
| throws Exception { | ||
| try (CloseableSession repoSession = repositorySystemSessionFactory | ||
| .newRepositorySessionBuilder(request) | ||
| .setWorkspaceReader(ideWorkspaceReader) |
There was a problem hiding this comment.
Won't that override the existing chained workspace reader ? is that the intent ?
There was a problem hiding this comment.
With this PR session factory does NOT set any workspace reader anymore (read PR description and see code), it is caller duty
There was a problem hiding this comment.
Yes, I don't question the change or responsibilities, but a possible change in behaviour.
The caller is BootstrapCoreExtensionManager and now responsible to set the workspace reader on the session. What I'm wondering is if this leads back to the same behaviour... I think before this PR, the workspace reader is to set a chained one, now, it's only the ide one...
There was a problem hiding this comment.
Oh, you mean IF request has one as well? Hm, let me recheck is that possible...
There was a problem hiding this comment.
yes, clearly IS possible (as copy of "origina" request is used), fixing...
There was a problem hiding this comment.
Fixed.
But your comment is wrong: session factory never used chained WSReader, it was ONLY the default maven using it. Before this PR, the session could be inited with request WS (if non null) OR the ide WS (that may be null).
There was a problem hiding this comment.
Fixed and also simplified, now chained WS omits possible null entries in collection, thus all these become one liner.
Maven4 seems sets but then drops/overrides some workspace readers. Partially due hazy borders who or what manages them, as role is split between session factory and session factory caller.
Changes:
Co-authored-by: Jonas Rutishauser jonas.rutishauser@alumni.ethz.ch
https://issues.apache.org/jira/browse/MNG-8005