-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-8023] New method + javadoc on Project #1387
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5d04ae5
[MNG-8023] New method + javadoc on Project
cstamas e7ee6d5
Reformat
cstamas 17de9de
Javadoc
cstamas 127763c
PR comment
cstamas 699c89f
Remove file registration, update javadoc
cstamas 3d0273d
Remove ref for now. Fails javadoc
cstamas 1579d45
More javadoc
cstamas 8a1d3e6
More javadoc
cstamas b28f32b
Another javadoc fix
cstamas 4910f31
Ssss
cstamas a4cac00
PR comment
cstamas c941566
Clean up methods, add getPomArtifact as well
cstamas f050f3b
More javadoc
cstamas 5123163
PR comments
cstamas 61473dd
PR comment
cstamas 9051f02
Fixes
cstamas 04f1a59
Javadoc
cstamas 601767f
Move method to prjManager instead. It belongs there.
cstamas 637ad25
Add requireBasedir, align iface + impl
cstamas 0383dbf
Undo wrong change
cstamas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at it, we're missing a paragraph to explain the behaviour in case a
ModelParser
is used (for example to parse a POM in a different syntax/language). I'll need to have a look at that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K, will wait for your evaluation...