Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8060] Use String#isEmpty instead of length #1420

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Feb 23, 2024

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Signed-off-by: crazyhzm <crazyhzm@apache.org>
# Conflicts:
#	maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
#	maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java
#	maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeImpl.java
@cstamas
Copy link
Member

cstamas commented Feb 26, 2024

@CrazyHZM I think we may conflict, but I'd really like to merge #1413 first as alpha-8 is out.

@CrazyHZM
Copy link
Member Author

@CrazyHZM I think we may conflict, but I'd really like to merge #1413 first as alpha-8 is out.

@cstamas
Don't have any burden, merge yours first, I can resolve the conflict later :)

# Conflicts:
#	maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
@gnodet gnodet added this to the 4.0.0-alpha-13 milestone Feb 27, 2024
@CrazyHZM CrazyHZM merged commit 83949a7 into apache:master Feb 28, 2024
18 checks passed
@CrazyHZM CrazyHZM deleted the MNG-8060 branch February 28, 2024 07:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants