[MNG-5726] Support regular expression matching in profile activation for

[kwin]

OS version

This requires using the reserved prefix "regex:" in the version element.

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MNG-XXX] SUMMARY,
  where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
• Also format the first line of the commit message like [MNG-XXX] SUMMARY.
  Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[gnodet]

Would it make sense to also support the easier glob: syntax then ?

[kwin]

@gnodet Is there general support for matching globs built into Java (apart from Files NIO)? I haven't found anything and quick googling revealed https://stackoverflow.com/questions/1247772/is-there-an-equivalent-of-java-util-regex-for-glob-type-patterns. So I would say, regex is good enough for now.

(I don't want to rely on external libraries like plexus-utils or maven-utils for such stuff TBH)

[gnodet]

@gnodet Is there general support for matching globs built into Java (apart from Files NIO)? I haven't found anything and quick googling revealed https://stackoverflow.com/questions/1247772/is-there-an-equivalent-of-java-util-regex-for-glob-type-patterns. So I would say, regex is good enough for now.

(I don't want to rely on external libraries like plexus-utils or maven-utils for such stuff TBH)

Fwiw, a workaround is already used in maven: https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/artifact/resolver/filter/ExclusionArtifactFilter.java
Maybe we can move the code in its own class in maven-core and reuse it ?

[kwin]

@gnodet Interesting. We can support glob: later once that refactoring is done. For now I would go with just regex:. Any concerns with that?

[gnodet]

@gnodet Interesting. We can support glob: later once that refactoring is done. For now I would go with just regex:. Any concerns with that?

None...

[gnodet]

Why not Os.OS_NAME and related ? @kwin

[kwin]

To streamline the testing approach with the other activators. Os.OS_NAME cannot be easily overwritten.

[kwin]

Compare with

maven/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java

Line 64 in ab6ec5b

String version = context.getSystemProperties().get("java.version");

and

maven/maven-model-builder/src/test/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivatorTest.java

Line 50 in ab6ec5b

props.setProperty("java.version", javaVersion);