Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8089] Introduce fat-JAR types #1459

Merged
merged 4 commits into from
Mar 29, 2024
Merged

[MNG-8089] Introduce fat-JAR types #1459

merged 4 commits into from
Mar 29, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Mar 27, 2024

These are dependency types to be used when dependency is "self contained", or is wanted be used as such: handle if like it has no dependencies, if any.


https://issues.apache.org/jira/browse/MNG-8089

These are dependency types to be used when dependency is "self contained",
or is wanted be used as such: handle if like it has no dependencies,
if any.

---

https://issues.apache.org/jira/browse/MNG-8089
@cstamas cstamas requested a review from gnodet March 27, 2024 15:04
@cstamas cstamas self-assigned this Mar 27, 2024
@cstamas
Copy link
Member Author

cstamas commented Mar 27, 2024

@desruisseaux ping

@desruisseaux
Copy link
Contributor

I suggest to provide only the fatjar type, without the classpath-fatjar and modular-fatjar for now, and modify the Javadoc of fatjar for saying that it goes on the classpath only. The reason is that a JAR file can contain at most one module-info.class file. So either the module-info or all JARs had to be removed, or either they were merged in some way. But the latter would be tricky, and the result would still not be the same as the separated JARs. So I think it is probably safer to said that a fat JAR is never modular.

@cstamas
Copy link
Member Author

cstamas commented Mar 27, 2024

This makes perfect sense, will do the changes soon

@cstamas
Copy link
Member Author

cstamas commented Mar 28, 2024

Updated PR

@cstamas cstamas marked this pull request as ready for review March 28, 2024 15:43
@cstamas cstamas merged commit c16f45d into apache:master Mar 29, 2024
13 checks passed
@cstamas cstamas deleted the MNG-8089 branch March 29, 2024 09:32
@gnodet gnodet added this to the 4.0.0-alpha-14 milestone Apr 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants