Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve maven startup time #1464

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Improve maven startup time #1464

merged 4 commits into from
Apr 3, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Apr 2, 2024

This saves 15-20% on the startup time on the maven project for example.
On bigger projects, most of time is spent in loading projects, so this becomes negligible.

@gnodet gnodet changed the title Boot JLine in async mode Improve maven startup time Apr 2, 2024
@gnodet gnodet marked this pull request as ready for review April 2, 2024 15:00
Copy link
Contributor

@rmannibucau rmannibucau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, ideally if we need more init we can use a global shared forkjoin pool (instead of ExecutorService executor = Executors.newSingleThreadExecutor(); in jline module) but good enough for now

@gnodet gnodet merged commit 084e3f9 into apache:master Apr 3, 2024
13 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants