[MNG-8084] Change six remaining imports of ModelVersionParser.
#1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit aims to complete d075fe7, which moved `ModelVersionParser` interface from the `org.apache.maven.model.version` package to `org.apache.maven.api.services.model`. Completing this change is necessary for building `maven-plugin-tools` or `maven-plugin-testing`. This commit deletes the old interface for making sure that there is no accidental use. The old and new interfaces were identical except for the package names and the imports. As a result of this change, the following implementation classes are identical except for package names and imports: * `maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultModelVersionParser.java` * `maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultModelVersionParser.java`
cstamas
approved these changes
May 21, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to complete d075fe7, which moved
ModelVersionParserinterface from theorg.apache.maven.model.versionpackage toorg.apache.maven.api.services.model. Completing this change is necessary for buildingmaven-plugin-toolsormaven-plugin-testing.This commit deletes the old interface for making sure that there is no accidental use. The old and new interfaces were identical except for the package names and the imports. As a result of this change, the following implementation classes are identical except for package names and imports:
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultModelVersionParser.javamaven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultModelVersionParser.javaThis pull request does not resolve the duplication in above implementation classes.