Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8136] Update Eclipse Sisu to 0.9.0.M3 #1546

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented May 31, 2024

Update Eclipse Sisu to 0.9.0.M3


https://issues.apache.org/jira/browse/MNG-8136

@cstamas cstamas requested review from gnodet and kwin May 31, 2024 17:06
@cstamas cstamas self-assigned this May 31, 2024
@cstamas
Copy link
Member Author

cstamas commented May 31, 2024

@kwin this locally failed on me (it's maybe me), just heads up all fine, initially it was version mixup (hence binary breakage) later the EPL-2 license.

Fix class usage as well, using Sisu stuff.
Sisu went from EPL1 to EPL2
Copy link
Member

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us enable strict parsing at least for Maven 4.0

@cstamas
Copy link
Member Author

cstamas commented May 31, 2024

Will do once we sort out ITs, as something is fishy here: it fails on macOS only (and error seems m-p-p related)

pom.xml Show resolved Hide resolved
pom.xml Outdated
<enabled>true</enabled>
</snapshots>
<id>sonatype-snapshots</id>
<url>https://oss.sonatype.org/content/repositories/snapshots/</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the IT failure was fixed yesterday in apache/maven-integration-testing@4d1c998.

@cstamas cstamas changed the title Testing Eclipse Sisu update to upcoming 0.9.0.M3 Update Eclipse Sisu to 0.9.0.M3 Jun 3, 2024
@cstamas cstamas marked this pull request as ready for review June 3, 2024 17:39
@kwin
Copy link
Member

kwin commented Jun 3, 2024

We can get rid of the PathConverter in maven-core/src/main/java/org/apache/maven/configuration/internal/DefaultBeanConfigurator.java now!

@cstamas cstamas changed the title Update Eclipse Sisu to 0.9.0.M3 [MNG-8136] Update Eclipse Sisu to 0.9.0.M3 Jun 4, 2024
@cstamas cstamas merged commit 5e97703 into apache:master Jun 4, 2024
13 checks passed
@cstamas cstamas deleted the sisu-update branch June 4, 2024 06:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants