Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8135] Fix capital OS name can not activate profile #1549

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

liutang123
Copy link

[MNG-8135] Fix caplital OS name can not activate profile
Lowercase the os properties before checking.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@liutang123 liutang123 force-pushed the bug/MNG-8135 branch 2 times, most recently from 22d7b67 to aed0dfb Compare June 1, 2024 16:21
@liutang123
Copy link
Author

@kwin Hello, do you have time to have a look at thi PR?

@gnodet gnodet changed the title [MNG-8135] Fix caplital OS name can not activate profile [MNG-8135] Fix capital OS name can not activate profile Jun 3, 2024
@cstamas cstamas requested a review from kwin June 5, 2024 08:44
Copy link
Member

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this is indeed a regression. We need to update documentation around profile activation to explicitly mention case insensitivity on those fields.

@cstamas
Copy link
Member

cstamas commented Jun 5, 2024

Can we have a backport of this PR against maven-3.9.x branch? Or if pretty much trivial (as it is same code) I can cherry pick it back once merged.

@cstamas cstamas modified the milestones: 3.9.8, 4.0.0-beta-4 Jun 5, 2024
@kwin kwin merged commit 0456c7c into apache:master Jun 5, 2024
13 checks passed
@gnodet gnodet modified the milestones: 4.0.0-beta-4, 4.0.0 Jul 6, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants