Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8172] Fix site building #1594

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[MNG-8172] Fix site building #1594

merged 1 commit into from
Aug 16, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jul 4, 2024

@gnodet gnodet marked this pull request as ready for review July 4, 2024 06:57
@gnodet gnodet added this to the 4.0.0-beta-4 milestone Jul 4, 2024
@michael-o
Copy link
Member

Big question is now: Should the components in m-site-p rewritten to make things right? (for both Maven 3 and 4)

@gnodet
Copy link
Contributor Author

gnodet commented Jul 4, 2024

Big question is now: Should the components in m-site-p rewritten to make things right? (for both Maven 3 and 4)

Doxia 2.x can be used on Maven 3, right ? So if we fix it there, it may be sufficient, assuming we somehow force Maven 4 users to use m-site-p 4.x. Though I suppose once the work is done on Doxia 2.x, porting it to Doxia 1.x should not be too difficult...

@gnodet
Copy link
Contributor Author

gnodet commented Jul 4, 2024

Big question is now: Should the components in m-site-p rewritten to make things right? (for both Maven 3 and 4)

Doxia 2.x can be used on Maven 3, right ? So if we fix it there, it may be sufficient, assuming we somehow force Maven 4 users to use m-site-p 4.x. Though I suppose once the work is done on Doxia 2.x, porting it to Doxia 1.x should not be too difficult...

Given apache/maven-doxia-sitetools#161, I assume the code does not build projects from local repository anymore. I need to check if m-site-p 4.x works correctly on Maven 4.0.0-beta-3 or not.

@gnodet
Copy link
Contributor Author

gnodet commented Jul 4, 2024

Big question is now: Should the components in m-site-p rewritten to make things right? (for both Maven 3 and 4)

Doxia 2.x can be used on Maven 3, right ? So if we fix it there, it may be sufficient, assuming we somehow force Maven 4 users to use m-site-p 4.x. Though I suppose once the work is done on Doxia 2.x, porting it to Doxia 1.x should not be too difficult...

Given apache/maven-doxia-sitetools#161, I assume the code does not build projects from local repository anymore. I need to check if m-site-p 4.x works correctly on Maven 4.0.0-beta-3 or not.

It does not, because the new DefaultSiteTools relies on MavenProject.getParent() which returns a MavenProject with getBasedir() == null when the parent has been loaded from the local repository. We may want to change some semantics on the longer term, but for now, I don't think there's an easy way to work around the situation. I think we should use this PR to restore the behaviour for next 4.x release.

@gnodet gnodet changed the title Fix site building [MNG-8172] Fix site building Jul 4, 2024
@michael-o
Copy link
Member

Big question is now: Should the components in m-site-p rewritten to make things right? (for both Maven 3 and 4)

Doxia 2.x can be used on Maven 3, right ? So if we fix it there, it may be sufficient, assuming we somehow force Maven 4 users to use m-site-p 4.x. Though I suppose once the work is done on Doxia 2.x, porting it to Doxia 1.x should not be too difficult...

I wouldn't put any effort into Doxia 1.x. Doxia 2.x is fully compatible with Maven 3 and intended to be used with 3.6.3+. m-site-p will be available for both Maven 3 and 4 with Doxia 2.x.

@gnodet gnodet requested review from cstamas and michael-o July 6, 2024 04:25
@gnodet gnodet modified the milestones: 4.0.0-beta-4, 4.0.0 Jul 6, 2024
@michael-o
Copy link
Member

Let me test this in the next few days.

@cstamas
Copy link
Member

cstamas commented Aug 12, 2024

Did testing show any results?

@michael-o
Copy link
Member

Still absent, will test end of week.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works for me.

@gnodet gnodet merged commit 40e4115 into apache:master Aug 16, 2024
13 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants