[MNG-8180] Fail install/deploy if rogue Maven Plugin metadata found #1611
Conversation
Resolver handles transparently the repository metadata, and in case of plugins it peeks into META-INF/maven/plugin.xml of given artifact JAR to figure out needed metadata bits (prefix, name, etc). But, this was done "blindly", while it is expected that GA of JAR artifact without classifier (requirement for maven plugins) and GA in embedded plugin metadata must be same. Decision here is to fail hard, prevent this being installed and deployed, as this is most probably wrong (unsure what maven-indexer or even Sonatype search would do in this case). --- https://issues.apache.org/jira/browse/MNG-8180
| } | ||
| } | ||
| } catch (RuntimeException e) { |
There was a problem hiding this comment.
IAPMEx? But lets have NPE and other fail the build as well, as below it is in comment, IOEx, PlexusXMLEx etc are and were swallowed.
There was a problem hiding this comment.
As other catch below catches all?
There was a problem hiding this comment.
I might be missing something, intent is "throw all unexpected ones" (or, swallow all expected ones, like IOEx, XML parsing and Plexus XML ones, these are all checked ones).
Also, the newly introduced IAPMEx is "unexpected" as well. All "unexpected" ones will fail the build, while all the "expected" ones are swallowed, as were since 1.9.0.
There was a problem hiding this comment.
Then I would just rethrow InvalidArtifactPluginMetadataException.
There was a problem hiding this comment.
K, I will merge this PR as is, and later we can refine.
Resolver handles transparently the repository metadata, and in case of plugins it peeks into META-INF/maven/plugin.xml of given artifact JAR to figure out needed metadata bits (prefix, name, etc).
But, this was done "blindly", while it is expected that GA of JAR artifact without classifier (requirement for maven plugins) and GA in embedded plugin metadata must be same.
Decision here is to fail hard, prevent this being installed and deployed, as this is most probably wrong (unsure what maven-indexer or even Sonatype search would do in this case).
https://issues.apache.org/jira/browse/MNG-8180