-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-8192] Consistently throw InvalidArtifactRTException for invalid #1637
[MNG-8192] Consistently throw InvalidArtifactRTException for invalid #1637
Conversation
@@ -202,6 +203,9 @@ private static Restriction parseRestriction(String spec) throws InvalidVersionSp | |||
} | |||
|
|||
public static VersionRange createFromVersion(String version) { | |||
if (DefaultArtifact.empty(version)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we throw here for null/empty string? If so, which exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Null as in line 95
coordinates This fixes throwing NPE for version being null.
fa05cf9
to
b2f0924
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All reasonable
assertThrows( | ||
InvalidArtifactRTException.class, | ||
() -> new DefaultArtifact( | ||
groupId, artifactId, (VersionRange) null, scope, type, classifier, artifactHandler, false)); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
coordinates
This fixes throwing NPE for version being null.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY
,where you replace
MNG-XXX
andSUMMARY
with the appropriate JIRA issue.[MNG-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.