[MNG-8180] Handle NPE due non-existent tags #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
approved these changes
Aug 10, 2024
cstamas
changed the title
slawekjaranowski
approved these changes
Aug 11, 2024
|
@cstamas should we remove that plugin.xml at the same time ? |
|
@gnodet yup, we could remove plugin.xml, and am unsure about the rest, as I see in history, they belong together. Also, they are being mention here https://cwiki.apache.org/confluence/display/MAVENOLD/Deterministic+Lifecycle+Planning and to me it seems like those are not even m3 -> m2 backward compat, but in fact m2.1 -> m2.0 (!!!) backward compat thing. |
|
but let's do it in separate JIRA IMO |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an NPE possibility when plugin.xml had no expected tags present.
Also: maven-compat has plugin.xml (!) w/o "name" tag, it NPEd and failed build. This was NOT picked up by CI as "rebuild itself" step does not install (just verify).
https://issues.apache.org/jira/browse/MNG-8180