[MNG-8210] Replace Maven "module" term by "subproject" #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
changed the title
cstamas
reviewed
Aug 13, 2024
| @@ -708,6 +708,9 @@ public List<Plugin> getBuildPlugins() { | |||
| } | |||
|
|
|||
| public List<String> getModules() { | |||
There was a problem hiding this comment.
Deprecate it? Or maybe does not matter, as in API 4 plugins have no reach to this class?
There was a problem hiding this comment.
Yes, I was assuming this change targets 4.x api and plugins, so I would not care about the v3 api.
api/maven-api-core/src/main/java/org/apache/maven/api/services/ModelBuilder.java
Outdated
Show resolved
Hide resolved
gnodet
changed the title
|
Shouldn't the subprojects be transformed to modules in the consumer pom? |
Actually, the modules/subprojects are build information, so not available in the consumer POM. |
…deprecated to modules field in model
Bukama
reviewed
Aug 17, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/plugin/annotations/Mojo.java
Outdated
Show resolved
Hide resolved
Bukama
reviewed
Aug 17, 2024
maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelValidator.java
Outdated
Show resolved
Hide resolved
Bukama
reviewed
Aug 17, 2024
maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
Outdated
Show resolved
Hide resolved
cstamas
approved these changes
Aug 27, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @desruisseaux initial commit to rename subproject #1649.
This PR adds
subprojectsto 4.1.0 POM, deprecatemodules, and add a discovery mechanism which kicks in when: