Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-8261] Remove jline-terminal-ffm direct dependency #1719

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MNG-8261] Remove jline-terminal-ffm direct dependency #1719

wants to merge 3 commits into from
+66 −7

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Sep 11, 2024 •
edited
Loading

@gnodet gnodet mentioned this pull request Sep 11, 2024
Closed
@gnodet gnodet added this to the 4.0.0-beta-5 milestone Sep 12, 2024
@gnodet gnodet changed the title Remove jline-terminal-ffm direct dependency [MNG-8261] Remove jline-terminal-ffm direct dependency Sep 17, 2024
@gnodet gnodet requested a review from cstamas September 17, 2024 20:50
cstamas
cstamas reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not we do this simpler? Maven really needs jansi-core, so everything else can be added in apache-maven "bundle" only, no?

@gnodet
Copy link
Contributor Author

gnodet commented Sep 18, 2024 •
edited
Loading

Could not we do this simpler? Maven really needs jansi-core, so everything else can be added in apache-maven "bundle" only, no?

Well, that's what I did, i.e. make sure maven-embedded only depends on jansi-core. However the maven-jline subproject actually depends on JLine (it provides plexus interactivity services based on JLine).
Btw, those services were broken, so I restored them, this can be tested easily by using mvn versions:set and using left/right arrow keys (compare Maven 3.x with this PR).

@gnodet gnodet mentioned this pull request Sep 18, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas cstamas left review comments

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-beta-5
Development

Successfully merging this pull request may close these issues.
2 participants
@gnodet @cstamas