Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-5600] Dependency management import should support exclusions #295

Closed
wants to merge 1 commit into from
Closed

[MNG-5600] Dependency management import should support exclusions #295

wants to merge 1 commit into from

Conversation

alex1989hu
Copy link

The original patch is made by: Christian Schulte schulte@apache.org
@ChristianSchulte

For more information kindly ask you to visit the original pull request #148

@alex1989hu
Copy link
Author

@olamy kind ping

@alex1989hu
Copy link
Author

/cc @khmarbaise could you please help to let this PR being merged? Thank you

@michael-o
Copy link
Member

@alex1989hu Is there an IT for that?

@alex1989hu
Copy link
Author

@alex1989hu Is there an IT for that?

Yes, it is written in the referenced PR #148 --> maven-integration-testing/pull/30

@valdar
Copy link
Member

valdar commented May 7, 2020

Any update on this?

@michael-o
Copy link
Member

Completely forgot. Can someone rebase here?

@alex1989hu
Copy link
Author

alex1989hu commented May 7, 2020

Completely forgot. Can someone rebase here?

Sure

UPDATE: Done

The original patch is made by: Christian Schulte <schulte@apache.org>
@rfscholte
Copy link
Contributor

IT of github.com/apache/maven-integration-testing/pull/30 needs to be rebased too.

@alex1989hu
Copy link
Author

IT of github.com/apache/maven-integration-testing/pull/30 needs to be rebased too.

Rebased here: apache/maven-integration-testing#59

@michael-o
Copy link
Member

@slachiewicz You have created a branch for this. Do you want to pursue this PR?

@renatoathaydes
Copy link

Hey, is this feature undesirable for Maven to have? Or is this PR being blocked for other reasons? Either way is fine with me, just wanted to know if there's a reason there's been no activity here in nearly 2 years now.

@djohle
Copy link

djohle commented May 4, 2022

Not to be a "me 2" here, but I ran into this issue today. But I figured I would at least comment to show my support of including this change.

I was centralizing some repeatedly used dependencies in a multi-module project via dependencyManagement in the parent POM. These dependencies came with some excludes (fortunately the same one in each usage), so I put those in the parent as well. Was quite surprised that building my application resulted in 2x the size of the final package and a complete failure to function at all (there is a reason I do these exclusions!). To work around this I had to re-add the exclusions to each of the relevant modules.

Like the previous comment...I can totally understand if there are reasons for blockage, but those are not apparent. Looking back to the beginning, this enhancement/fix is over 4 years old now! Kind of sucks to see an already-solved issues be ignored like this.

@michael-o
Copy link
Member

@cstamas @gnodet @hboutemy Is this something we can consider for 4? I don't think it would be appropriate for 3.9.0, but it is opt-in only. WDYT?

@famod
Copy link
Contributor

famod commented Jul 14, 2022

@michael-o

I would very much appreciate if that would end up in 3.9 (as you said it's opt in and only little code is touched).
Otherwise it will be practically unusable for years to come, given that big projects like Quarkus cannot/will not force users to use the latest maven version and Maven 4 adoption will most likely take considerably more time that 3.9.

@mistriel
Copy link

mistriel commented Aug 28, 2022

Also bumped into that issue today, I was kind of shocked that it's not supported OOB. For me it's blocks the creation of parent pom for all microservices that imports spring-boot-dependencies (very common) where importing another project bom that has conflict with spring-boot-dependencies. Guy's this is a must !

pzygielo pushed a commit to pzygielo/maven that referenced this pull request Jan 4, 2023
@JWT007
Copy link

JWT007 commented Feb 15, 2023

Another +1 "me too"... would really like to see this feature!

@Lonzak
Copy link

Lonzak commented Apr 17, 2023

This is another +1 - today ran into this problem...
@alex1989hu I think the original merge request needs another update (conflicts exists)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.