[MNG-4645] Move Central repo definition out of Maven's core so it can… #419
Conversation
| @@ -244,6 +244,35 @@ under the License. | |||
| </properties> | |||
| </profile> | |||
| --> | |||
| <profile> | |||
| <activation> | |||
There was a problem hiding this comment.
To me we're now abusing a profile because it is not yet possible to specify these at a higher level. The default profile could contain much more.
There was a problem hiding this comment.
That's correct, but we don't have a better way. Settings with Maven 5 could natively support repositories. Do you see a better way?
There was a problem hiding this comment.
To me the settings.xml is a Maven specific file (unlike the pom.xml). I see this as an opportunity to improve the settings.xml right now. I don't like the idea of a temporary solution now of which we know it'll be changed. Those temporary hybrid style settings will be there forever.
There was a problem hiding this comment.
So you want to bump settings model to 2.0.0 and introduce repos there? What will happen when pre-4.0.0 will try to read this settings file?
There was a problem hiding this comment.
version 1.2.0 would be good enough, we're only adding stuff, not breaking things.
And we're talking about config/settings.xml, not .m2./settings.xml. It must be possible to keep the latter at 1.0.0 or 1.1.0, while improving the first one.
There was a problem hiding this comment.
So do you want to move this after settings 1.2.0 or can we start with a profile and then move to a separate repo? Implementing 1.2.0 will take some time...
There was a problem hiding this comment.
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
Outdated
Show resolved
Hide resolved
| <activeProfiles> | ||
| <activeProfile>alwaysActiveProfile</activeProfile> | ||
| <activeProfile>anotherAlwaysActiveProfile</activeProfile> | ||
| <activeProfile>maven:core:central-repo</activeProfile> |
There was a problem hiding this comment.
I don't like this approach. Let's invest time to do it correct, i.e. without profiles
There was a problem hiding this comment.
I can't offer anything better until settings don't change. Take your time and let me know.
… be more easily changed
| <releases> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| </pluginRepository> |
There was a problem hiding this comment.
Why is this policy not on the repo as well?
| <activeProfiles> | ||
| <activeProfile>alwaysActiveProfile</activeProfile> | ||
| <activeProfile>anotherAlwaysActiveProfile</activeProfile> | ||
| <activeProfile>maven:core:central-repo</activeProfile> |
There was a problem hiding this comment.
@gnodet, this is redudant now, no?
|
@gnodet Is this superseded? |
… be more easily changed
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.