Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-5659] Project level settings.xml #839

Closed

Conversation

nielsbasjes
Copy link
Contributor

@nielsbasjes nielsbasjes commented Oct 20, 2022

JIRA issue: https://issues.apache.org/jira/browse/MNG-5659

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I'm one of the committers for Apache Avro and Apache Flink.


This is a first attempt to make it possible to automatically read a settings file which is part of a project. The situation where this is useful to me is in multi module projects within a company where a mandatory mirror must be used.

The initial version of this pull request is incomplete as it is only the code to make it work, no tests and no documentation at this point.
I will write all of those once you have approved the basic implementation direction and the core choices I have made so far.

Right now:

  • The default assumed location is ${project.basedir}/.mvn/settings.xml
  • If this file is present it is read with
    • a prio higher than the global settings
    • a lower prio than the user settings; I'm unsure if this is correct.
  • It is the same file spec as the normal settings.xml, yet in the project level context some of those settings may not make any sense.

Looking forward to your feedback.

@gnodet gnodet closed this Jun 23, 2023
@oymy
Copy link

oymy commented Sep 20, 2023

expecting this feature

@gnodet
Copy link
Contributor

gnodet commented Sep 20, 2023

Superseded by #1059

@nielsbasjes nielsbasjes deleted the MNG-5659-ProjectSettings branch November 5, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants