-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7338] Automatically activate batch-mode and make output quiet when running in CI. #869
Merged
gnodet
merged 2 commits into
master
from
feature/MNG-7338-automatic-non-interactive-mode-in-ci
Jun 8, 2023
Merged
[MNG-7338] Automatically activate batch-mode and make output quiet when running in CI. #869
gnodet
merged 2 commits into
master
from
feature/MNG-7338-automatic-non-interactive-mode-in-ci
Jun 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmannibucau
reviewed
Nov 10, 2022
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
Outdated
Show resolved
Hide resolved
MartinKanters
force-pushed
the
feature/MNG-7338-automatic-non-interactive-mode-in-ci
branch
from
November 11, 2022 08:19
2a87384
to
811592c
Compare
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
Outdated
Show resolved
Hide resolved
MartinKanters
force-pushed
the
feature/MNG-7338-automatic-non-interactive-mode-in-ci
branch
from
November 18, 2022 15:43
811592c
to
9145ad1
Compare
MartinKanters
force-pushed
the
feature/MNG-7338-automatic-non-interactive-mode-in-ci
branch
from
January 12, 2023 11:12
9145ad1
to
0e4ac27
Compare
MartinKanters
force-pushed
the
feature/MNG-7338-automatic-non-interactive-mode-in-ci
branch
from
March 24, 2023 09:43
0e4ac27
to
f6bb2be
Compare
michael-o
requested changes
Mar 27, 2023
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
Outdated
Show resolved
Hide resolved
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
Outdated
Show resolved
Hide resolved
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
Outdated
Show resolved
Hide resolved
gnodet
approved these changes
Jun 1, 2023
Thanks for merging master in and the approval @gnodet . I'm on holidays for the next couple of weeks, so feel free to merge it, if you want. |
gnodet
force-pushed
the
feature/MNG-7338-automatic-non-interactive-mode-in-ci
branch
from
June 6, 2023 23:07
197df78
to
782f14c
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion with @rmannibucau, @slawekjaranowski and @michael-o, I think this is the best solution.
The env CI check is done in Java code, making it easy to unit test. Also, a new flag had to be added to de-activate the CI=true behavior (named
--force-interactive
). To make it consistent I created an additional flag/alias to -B (--non-interactive
). The flags were suggested by @michael-o since it's also used in other widely used CLI tools such as SVN.Happy to hear your thoughts.
Relevant maven-integration-testing PR
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY
, where you replaceMNG-XXX
and
SUMMARY
with the appropriate JIRA issue. Best practice is to use the JIRA issuetitle in the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.