-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build on Apple M1 clip 2021 #16639
Comments
It seems barely bump the protoc version doesn't fix the issue entirely. Meet:
|
Install Rosetta (see google/protobuf-gradle-plugin#543 (comment)) workaround the issue. However, we may bump version of protoc and grpc-java to get native osx-aarch_64 binary. protoc provides one at the moment while grpc-java plugin doesn't. |
I'd like to keep it open since we need some workaround instead of a native solution. This issue may remind me to see whether upstream provides a real osx-aarch_64 protoc-gen-grpc-java binary. Upstream issue: grpc/grpc-java#7690 |
now ,master branch can build in m1 (works for me) |
@leizhiyuan do you install Rosetta 2.0? |
yes.. |
After consideration, I tend to close the issue as I cannot uninstall or disable Rosetta and reproduce the issue anymore. When grpc/grpc-java#7690 gets resolved we may directly try to upgrade the dep version. Or someone who has an M1 without Rosetta environment can verify then. |
Looks like apache-pulsar still does not support native arm build, can we maybe reopen this issue (or should I create a new one)? Also, github has arm build support now with macos-14 runner. https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ |
Describe the bug
To Reproduce
On a macOS machine with properties:
Clone pulsar code and execute
mvn clean install -DskipTests
Expected behavior
Successfully compiled.
Additional context
protoc 3.19.2 dists osx-aarch_64 binary as an alias to the osx-x86_64 one.
Bumping the version to 3.21.2 resolves the issue.
I'll prepare a PR for this issue.
The text was updated successfully, but these errors were encountered: