[fix][broker] Fix 'Disabled replicated subscriptions controller' logic and logging #23142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subscriptions controller' when isCurrentlyEnabled is equal to true.
nodece
approved these changes
Aug 12, 2024
lhotari
changed the title
poorbarcode
approved these changes
Aug 12, 2024
|
@hanmz Please check the failed tests,thanks |
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Aug 13, 2024
…c and logging (apache#23142) (cherry picked from commit 9bf714f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 14, 2024
…c and logging (apache#23142) (cherry picked from commit 9bf714f) (cherry picked from commit 4235a53)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2024
…c and logging (apache#23142) (cherry picked from commit 9bf714f) (cherry picked from commit 4235a53)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 20, 2024
…c and logging (apache#23142) (cherry picked from commit 9bf714f)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When config
enableReplicatedSubscriptions=false, the replicated subscriptions controller will never be started. But we will still see the log of theDisabled replicated subscriptions controller. In fact, we should not see the log because it has never been started.Modifications
Modify judgment conditions, only if replicatedSubscriptionsController has been started do we need to disabled it.
Documentation
Verifying this change
All unit tests passed, not have any behavior change.
docdoc-requireddoc-not-neededdoc-complete