Fix instance query in JDBC implementation.(#11023) (#11024)

Co-authored-by: weixiang1862 <weixiang1862@gmail.com>
apache · Jun 29, 2023 · 137fb64 · 137fb64
1 parent a3adc3d
commit 137fb64
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
@@ -27,10 +27,11 @@
 * Packages with name `recevier` are renamed to `receiver`.
 * `BanyanDBMetricsDAO` handles `storeIDTag` in `multiGet` for `BanyanDBModelExtension`.
 * Fix endpoint grouping-related logic and enhance the performance of PatternTree retrieval. 
-* Fix metric session cache saving after batch insert when using `mysql-connector-java`
+* Fix metric session cache saving after batch insert when using `mysql-connector-java`.
 * Support dynamic UI menu query.
 * Add comment for `docker/.env` to explain the usage.
 * Fix wrong environment variable name `SW_OTEL_RECEIVER_ENABLED_OTEL_RULES` to right `SW_OTEL_RECEIVER_ENABLED_OTEL_METRICS_RULES`.
+* Fix instance query in JDBC implementation.
 
 #### UI
 

diff --git a/...org/apache/skywalking/oap/server/storage/plugin/jdbc/common/dao/JDBCMetadataQueryDAO.java b/...org/apache/skywalking/oap/server/storage/plugin/jdbc/common/dao/JDBCMetadataQueryDAO.java
@@ -156,12 +156,7 @@ public List<ServiceInstance> listInstances(Duration duration,
 
         final var minuteTimeBucket = TimeBucket.getMinuteTimeBucket(duration.getStartTimestamp());
 
-        final var tables = tableHelper.getTablesForRead(
-            InstanceTraffic.INDEX_NAME,
-            duration.getStartTimeBucket(),
-            duration.getEndTimeBucket()
-        );
-
+        final var tables = tableHelper.getTablesWithinTTL(InstanceTraffic.INDEX_NAME);
         for (String table : tables) {
             final var sqlAndParameters = buildSQLForListInstances(serviceId, minuteTimeBucket, table);
             results.addAll(