Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only list healthy Pods when forming OAP cluster #10969

Merged
merged 6 commits into from
Jun 21, 2023
Merged

Only list healthy Pods when forming OAP cluster #10969

merged 6 commits into from
Jun 21, 2023

Conversation

kezhenxu94
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

wu-sheng
wu-sheng previously approved these changes Jun 20, 2023
View reviewed changes
@wu-sheng wu-sheng added this to the 9.6.0 milestone Jun 20, 2023
@wu-sheng wu-sheng added the test Test requirements about performance, feature or before release. label Jun 20, 2023
@kezhenxu94 kezhenxu94 changed the title Wait for UI readiness before continue Connect to OAP instead of UI in E2E tests Jun 20, 2023
wu-sheng
wu-sheng previously approved these changes Jun 20, 2023
View reviewed changes
wu-sheng
wu-sheng previously approved these changes Jun 20, 2023
View reviewed changes
@wu-sheng
Copy link
Member

One question, do we miss UI test? If the request doesn't bypass UI, how to test it works?

@kezhenxu94 kezhenxu94 closed this Jun 21, 2023
@kezhenxu94 kezhenxu94 deleted the e2e branch June 21, 2023 01:46
@kezhenxu94 kezhenxu94 restored the e2e branch June 21, 2023 01:48
@kezhenxu94 kezhenxu94 reopened this Jun 21, 2023
wu-sheng
wu-sheng previously approved these changes Jun 21, 2023
View reviewed changes
@wu-sheng
Copy link
Member

Please rename the PR title.

@kezhenxu94 kezhenxu94 changed the title Connect to OAP instead of UI in E2E tests Only list healthy Pods when forming OAP cluster Jun 21, 2023
@wu-sheng
Copy link
Member

1.7 and 1.16 are unstable this time. It is strange. Another PR works.

@wu-sheng wu-sheng merged commit cf696ab into apache:master Jun 21, 2023
184 checks passed
@kezhenxu94 kezhenxu94 deleted the e2e branch June 21, 2023 14:10
@kezhenxu94 kezhenxu94 mentioned this pull request Jun 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
test Test requirements about performance, feature or before release.
Projects
None yet
Milestone
9.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kezhenxu94 @wu-sheng