Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in metrics query when the metric is not exist. #10980

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Fix NPE in metrics query when the metric is not exist. #10980

merged 3 commits into from
Jun 23, 2023

Conversation

wankai123
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wankai123 wankai123 added the bug Something isn't working and you are sure it's a bug! label Jun 22, 2023
@wankai123 wankai123 added this to the 9.6.0 milestone Jun 22, 2023
@wankai123 wankai123 requested a review from wu-sheng June 22, 2023 13:53
wu-sheng
wu-sheng previously approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you plan to fix the dashboard in another PR?

wu-sheng
wu-sheng previously approved these changes Jun 22, 2023
View reviewed changes
@wu-sheng wu-sheng merged commit 4d19199 into apache:master Jun 23, 2023
182 checks passed
@wankai123 wankai123 deleted the fix-metric-query branch June 24, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working and you are sure it's a bug!
Projects
None yet
Milestone
9.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wankai123 @wu-sheng