Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metric session cache saving when using mysql-connector-java.(#11009) #11012

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix metric session cache saving when using mysql-connector-java.(#11009) #11012

merged 1 commit into from
Jun 28, 2023

Conversation

weixiang1862
Copy link
Member

Fix metric session cache saving when using mysql-connector-java

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

@wu-sheng wu-sheng added this to the 9.6.0 milestone Jun 28, 2023
@wu-sheng wu-sheng added the bug Something isn't working and you are sure it's a bug! label Jun 28, 2023
@wu-sheng wu-sheng requested a review from kezhenxu94 June 28, 2023 08:14
wu-sheng
wu-sheng approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit dfba1c6 into apache:master Jun 28, 2023
151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working and you are sure it's a bug!
Projects
None yet
Milestone
9.6.0
Development

Successfully merging this pull request may close these issues.

[Bug] BatchSQLExecutor did not save the metric sessionCache after batch insert when using mysql storage
3 participants
@weixiang1862 @wu-sheng @kezhenxu94