WW-5340 Preliminary refactor of OgnlUtil #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
WW-5340-ognlutil-refactor
branch
from
14d3435
to
65ff242
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java
Dismissed
Show dismissed
Hide dismissed
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5340
I've refactored this class to improve both readability and maintainability.
My primary goal was to consolidate calls to ognl.Ognl, specifically the following functions:
#getValue: 5 calls to 1#setValue: 2 calls to 1#parseExpression: 4 calls to 1Functionally, there are only 2 changes:
OgnlUtil#setValue