[WW-5346] replace BeanManager::createInjectionTarget #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it was deprecated in CDI 1.1 and removed in CDI 4.0 (Jakarta EE 10)
|
Nice, could you create a JIRA ticket to link with this PR? Thanks in advance! |
|
Sure, I just requested an account and will create the ticket once I have access. I see one of the build checks failed. Is that a known issue? Doesn't seem like something I could have broken, but you never know 😀 |
Already approved :)
Yes, it's known issue, don't bother :) |
lukaszlenart
changed the title
kusalk
reviewed
Sep 18, 2023
plugins/cdi/src/main/java/org/apache/struts2/cdi/CdiObjectFactory.java
Outdated
Show resolved
Hide resolved
kusalk
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the recommended alternative, because it was deprecated in CDI 1.1 and removed in CDI 4.0 (Jakarta EE 10).
This resolves the CDI plugin's only hard incompatibility with Jakarta EE 10.
It can then be used in Jakarta EE 10 applications provided the package names are adapted (e.g. using Eclipse Transformer).