JakartaEE modules #810
Merged
JakartaEE modules #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszlenart
force-pushed
the
feature/jakarta-modules
branch
from
c25e0e6
to
41f4485
Compare
lukaszlenart
force-pushed
the
feature/jakarta-modules
branch
from
41f4485
to
26bb35e
Compare
lukaszlenart
requested review from
aleksandr-m,
yasserzamani,
sdutry,
cnenning and
kusalk
|
FYI @jdyer1 |
|
I agree this is the right thing to do. We shouldn't break dev experience with their IDEs! |
kusalk
reviewed
Dec 28, 2023
pom.xml
Outdated
| @@ -305,10 +303,10 @@ | |||
| <useDefaultExcludes>true</useDefaultExcludes> | |||
| <addDefaultLicenseMatchers>false</addDefaultLicenseMatchers> | |||
| <licenses> | |||
| <licens implementation="org.apache.rat.analysis.license.ApacheSoftwareLicense20" /> | |||
| <licens implementation="org.apache.rat.analysis.license.ApacheSoftwareLicense20"/> | |||
There was a problem hiding this comment.
Right, it's a typo but it doesn't matter as this an element of an array. Yet I fixed it :)
| </plugins> | ||
| </build> | ||
| <dependencies> | ||
| <dependency> |
There was a problem hiding this comment.
@jdyer1 Do you recall why this dependency was required? It doesn't seem like we needed it before
There was a problem hiding this comment.
Looks like a valid dependency
[ERROR] import org.apache.velocity.tools.ToolContext;
There was a problem hiding this comment.
Oh I see, it was previously included transitively by velocity-tools-view, makes sense
kusalk
approved these changes
Dec 28, 2023
|
kusalk
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves JakartaEE related modules into a dedicated subdirectory
Depends on #809