Fix original file upload to use actual file name rather than uploadxxx.tmp #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszlenart
reviewed
Mar 8, 2024
| @@ -337,7 +337,7 @@ public UploadedFile<T>[] getFile(String fieldName) { | |||
| */ | |||
| public String[] getFileNames(String fieldName) { | |||
| return uploadedFiles.getOrDefault(fieldName, Collections.emptyList()).stream() | |||
| .map(file -> getCanonicalName(file.getName())) | |||
| .map(file -> getCanonicalName(file.getOriginalName())) | |||
There was a problem hiding this comment.
But the same is on 6.xx, see here
There was a problem hiding this comment.
I think I found where this bug comes from, Commons FileItem.getName() returns:
Returns the original filename in the client's filesystem, as provided by the browser (or other client software)
and UploadedFile.getName() returns name of the uploaded file on the server side, so you are right.
lukaszlenart
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the original file upload and it now does not work.
I get an error where its using the wrong file name ie upload5549a568d9794ef5b654da83d079613500000045.tmp rather than the
actual file name. This fixes the original upload.
I also modified one of my uploads to use the UploadedFilesAware. To get the original file name to save on the server I use
The method getOriginalName() text says "original file name from upload source" so it looks correct.