Skip to content

Commit

Permalink
fix(logging): Filter out undefined columns
Browse files Browse the repository at this point in the history
  • Loading branch information
john-bodley committed Jan 2, 2024
1 parent 90a3d68 commit 9dc9606
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,9 @@ class Chart extends React.Component {
changeFilter(newSelectedValues = {}) {
this.props.logEvent(LOG_ACTIONS_CHANGE_DASHBOARD_FILTER, {
id: this.props.chart.id,
columns: Object.keys(newSelectedValues),
columns: Object.keys(newSelectedValues).filter(
key => newSelectedValues[key] !== null,

Check warning on line 278 in superset-frontend/src/dashboard/components/gridComponents/Chart.jsx

View check run for this annotation

Codecov / codecov/patch

superset-frontend/src/dashboard/components/gridComponents/Chart.jsx#L278

Added line #L278 was not covered by tests
),
});
this.props.changeFilter(this.props.chart.id, newSelectedValues);
}
Expand Down

0 comments on commit 9dc9606

Please sign in to comment.