Skip to content

Commit

Permalink
fix save.test.js
Browse files Browse the repository at this point in the history
  • Loading branch information
kstrz committed Jan 12, 2021
1 parent f29a096 commit de82da5
Showing 1 changed file with 149 additions and 144 deletions.
293 changes: 149 additions & 144 deletions superset-frontend/cypress-base/cypress/integration/dashboard/save.test.js
Original file line number Diff line number Diff line change
@@ -1,144 +1,149 @@
// /**
// * Licensed to the Apache Software Foundation (ASF) under one
// * or more contributor license agreements. See the NOTICE file
// * distributed with this work for additional information
// * regarding copyright ownership. The ASF licenses this file
// * to you under the Apache License, Version 2.0 (the
// * "License"); you may not use this file except in compliance
// * with the License. You may obtain a copy of the License at
// *
// * http://www.apache.org/licenses/LICENSE-2.0
// *
// * Unless required by applicable law or agreed to in writing,
// * software distributed under the License is distributed on an
// * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// * KIND, either express or implied. See the License for the
// * specific language governing permissions and limitations
// * under the License.
// */
//
// import shortid from 'shortid';
// import { WORLD_HEALTH_DASHBOARD } from './dashboard.helper';
//
// function openDashboardEditProperties() {
// cy.get('.dashboard-header [data-test=edit-alt]').click();
// cy.get('#save-dash-split-button').trigger('click', { force: true });
// cy.get('.dropdown-menu').contains('Edit dashboard properties').click();
// }
//
// describe('Dashboard save action', () => {
// beforeEach(() => {
// cy.server();
// cy.login();
// cy.visit(WORLD_HEALTH_DASHBOARD);
// });
//
// it('should save as new dashboard', () => {
// cy.get('#app').then(data => {
// const bootstrapData = JSON.parse(data[0].dataset.bootstrap);
// const dashboard = bootstrapData.dashboard_data;
// const dashboardId = dashboard.id;
// cy.route('POST', `/superset/copy_dash/${dashboardId}/`).as('copyRequest');
//
// cy.get('[data-test="more-horiz"]').trigger('click', { force: true });
// cy.get('[data-test="save-as-menu-item"]').trigger('click', {
// force: true,
// });
// cy.get('[data-test="modal-save-dashboard-button"]').trigger('click', {
// force: true,
// });
// });
// });
//
// it('should save/overwrite dashboard', () => {
// cy.get('[data-test="grid-row-background--transparent"]').within(() => {
// cy.get('.box_plot', { timeout: 10000 }).should('be.visible');
// });
// // should load chart
// cy.get('.dashboard-grid', { timeout: 50000 }); // wait for 50 secs
//
// // remove box_plot chart from dashboard
// cy.get('[data-test="edit-alt"]').click({ timeout: 5000 });
// cy.get('[data-test="dashboard-delete-component-button"]')
// .should('be.visible', { timeout: 10000 })
// .last()
// .trigger('click');
// cy.get('[data-test="grid-container"]')
// .find('.box_plot')
// .should('not.be.visible');
//
// cy.route('POST', '/superset/save_dash/**/').as('saveRequest');
// cy.get('[data-test="dashboard-header"]')
// .find('[data-test="header-save-button"]')
// .contains('Save')
// .trigger('click', { force: true });
// // go back to view mode
// cy.wait('@saveRequest');
// cy.get('[data-test="dashboard-header"]')
// .find('[data-test="edit-alt"]')
// .click();
// cy.get('[data-test="grid-container"]')
// .find('.box_plot', { timeout: 20000 })
// .should('not.be.visible');
// });
//
// // TODO: Fix broken test
// xit('should save after edit', () => {
// cy.get('.dashboard-grid', { timeout: 50000 }) // wait for 50 secs to load dashboard
// .then(() => {
// const dashboardTitle = `Test dashboard [${shortid.generate()}]`;
//
// openDashboardEditProperties();
//
// // open color scheme dropdown
// cy.get('.ant-modal-body')
// .contains('Color Scheme')
// .parents('.ControlHeader')
// .next('.Select')
// .click()
// .then($colorSelect => {
// // select a new color scheme
// cy.wrap($colorSelect)
// .find('.Select__option')
// .first()
// .next()
// .click();
// });
//
// // remove json metadata
// cy.get('.ant-modal-body')
// .contains('Advanced')
// .click()
// .then(() => {
// cy.get('#json_metadata').type('{selectall}{backspace}');
// });
//
// // update title
// cy.get('.ant-modal-body')
// .contains('Title')
// .siblings('input')
// .type(`{selectall}{backspace}${dashboardTitle}`);
//
// // save edit changes
// cy.get('.ant-modal-footer')
// .contains('Save')
// .click()
// .then(() => {
// // assert that modal edit window has closed
// cy.get('.ant-modal-body').should('not.exist');
//
// // save dashboard changes
// cy.get('.dashboard-header').contains('Save').click();
//
// // assert success flash
// cy.contains('saved successfully').should('be.visible');
//
// // assert title has been updated
// cy.get('.editable-title [data-test="editable-title-input"]').should(
// 'have.value',
// dashboardTitle,
// );
// });
// });
// });
// });
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import shortid from 'shortid';
import { WORLD_HEALTH_DASHBOARD } from './dashboard.helper';

function openDashboardEditProperties() {
cy.get('.dashboard-header [data-test=edit-alt]').click();
cy.get('#save-dash-split-button').trigger('click', { force: true });
cy.get('.dropdown-menu').contains('Edit dashboard properties').click();
}

describe('Dashboard save action', () => {
beforeEach(() => {
cy.server();
cy.login();
cy.visit(WORLD_HEALTH_DASHBOARD);
cy.get('#app').then(data => {
const bootstrapData = JSON.parse(data[0].dataset.bootstrap);
const dashboard = bootstrapData.dashboard_data;
const dashboardId = dashboard.id;
cy.route('POST', `/superset/copy_dash/${dashboardId}/`).as('copyRequest');

cy.get('[data-test="more-horiz"]').trigger('click', { force: true });
cy.get('[data-test="save-as-menu-item"]').trigger('click', {
force: true,
});
cy.get('[data-test="modal-save-dashboard-button"]').trigger('click', {
force: true,
});
});
});

it('should save as new dashboard', () => {
cy.wait('@copyRequest').then(xhr => {
expect(xhr.response.body.dashboard_title).to.not.equal(
`World Bank's Data`,
);
});
});

it('should save/overwrite dashboard', () => {
cy.get('[data-test="grid-row-background--transparent"]').within(() => {
cy.get('.box_plot', { timeout: 10000 }).should('be.visible');
});
// should load chart
cy.get('.dashboard-grid', { timeout: 50000 }); // wait for 50 secs

// remove box_plot chart from dashboard
cy.get('[data-test="edit-alt"]').click({ timeout: 5000 });
cy.get('[data-test="dashboard-delete-component-button"]')
.should('be.visible', { timeout: 10000 })
.last()
.trigger('click');
cy.get('[data-test="grid-container"]')
.find('.box_plot')
.should('not.be.visible');

cy.route('POST', '/superset/save_dash/**/').as('saveRequest');
cy.get('[data-test="dashboard-header"]')
.find('[data-test="header-save-button"]')
.contains('Save')
.trigger('click', { force: true });
// go back to view mode
cy.wait('@saveRequest');
cy.get('[data-test="dashboard-header"]')
.find('[data-test="edit-alt"]')
.click();
cy.get('[data-test="grid-container"]')
.find('.box_plot', { timeout: 20000 })
.should('not.be.visible');
});

// TODO: Fix broken test
xit('should save after edit', () => {
cy.get('.dashboard-grid', { timeout: 50000 }) // wait for 50 secs to load dashboard
.then(() => {
const dashboardTitle = `Test dashboard [${shortid.generate()}]`;

openDashboardEditProperties();

// open color scheme dropdown
cy.get('.ant-modal-body')
.contains('Color Scheme')
.parents('.ControlHeader')
.next('.Select')
.click()
.then($colorSelect => {
// select a new color scheme
cy.wrap($colorSelect)
.find('.Select__option')
.first()
.next()
.click();
});

// remove json metadata
cy.get('.ant-modal-body')
.contains('Advanced')
.click()
.then(() => {
cy.get('#json_metadata').type('{selectall}{backspace}');
});

// update title
cy.get('.ant-modal-body')
.contains('Title')
.siblings('input')
.type(`{selectall}{backspace}${dashboardTitle}`);

// save edit changes
cy.get('.ant-modal-footer')
.contains('Save')
.click()
.then(() => {
// assert that modal edit window has closed
cy.get('.ant-modal-body').should('not.exist');

// save dashboard changes
cy.get('.dashboard-header').contains('Save').click();

// assert success flash
cy.contains('saved successfully').should('be.visible');

// assert title has been updated
cy.get('.editable-title [data-test="editable-title-input"]').should(
'have.value',
dashboardTitle,
);
});
});
});
});

0 comments on commit de82da5

Please sign in to comment.