Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply button gets pushed out of filter box when the filter box is small with too many filter values selected #11419

Closed
junlincc opened this issue Oct 25, 2020 · 4 comments
Closed

Apply button gets pushed out of filter box when the filter box is small with too many filter values selected #11419

junlincc opened this issue Oct 25, 2020 · 4 comments
Assignees
@kkucharc
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@junlincc
Copy link
Member

junlincc commented Oct 25, 2020 •
edited
Loading

Expected results

Textbox width should adjust accordingly depends on the size of the filter box.
apply fixed height when there are many filter values selected in one field, and display only a limited number of values that fits
Apply button should always be in the box.
Screen Shot 2020-10-25 at 10 02 50 AM

Actual results

Screen Shot 2020-10-25 at 10 00 14 AM

Tested on latest master
@junlincc junlincc added the !deprecated-label:bug Deprecated label - Use #bug instead label Oct 25, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@junlincc
Copy link
Member Author

@kkucharc 🙏

@kkucharc kkucharc self-assigned this Oct 26, 2020
@kkucharc kkucharc mentioned this issue Nov 5, 2020
Merged
6 tasks
@kkucharc
Copy link
Contributor

kkucharc commented Nov 5, 2020

We agreed to add the vertical scroll to whole Filter block as a workaround.

@junlincc
Copy link
Member Author

junlincc commented Dec 4, 2020

#11580 temporary solution, scroll bar for entire filter box. should revisit
ezgif-3-3a36512a9779

@junlincc junlincc closed this as completed Dec 4, 2020
@kkucharc kkucharc mentioned this issue Jan 4, 2021
Merged
7 tasks
@ktmud ktmud mentioned this issue Jan 12, 2021
Merged
6 tasks
ktmud added a commit to graceguo-supercat/superset that referenced this issue Jan 13, 2021
@ktmud
Proper fix for apache#11419
f2b0f07
ktmud added a commit that referenced this issue Jan 13, 2021
@ktmud
fix: do not show vertical scrollbar for charts in dashboard (#12478)
e9d66e9 
* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for #11419

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
villebro pushed a commit that referenced this issue Jan 13, 2021
@ktmud @villebro
fix: do not show vertical scrollbar for charts in dashboard (#12478)
b3e7ef2 
* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for #11419

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this issue Jan 14, 2021
@ktmud
fix: do not show vertical scrollbar for charts in dashboard (apache#1…
0547146 
…2478)

* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for apache#11419

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
etr2460 pushed a commit that referenced this issue Jan 25, 2021
@lyndsiWilliams @dpgaspar
@zhaoyongjie @geido @junlincc @ktmud @agatapst @villebro @michael-s-molina @kgabryje @rusackas @kkucharc @pkdotson @betodealmeida @xiangfu0 @aadel @amitmiran137 @hughhhh @bechob
docs: Fixed typo on line 348 (#12739)
51d1b66 
* release: bump to 1.0.0 and CHANGELOG

* fix(explore): long metric name display (#12387)

* fix(explore): long metric name display

* add tooltip to control

* chore: Show datasets when search input is empty (#12391)

* chore: Fix typo “Rest” to “Reset” (#12392)

* chore: upgrade eslint, babel, and prettier (#12393)

* feat(explore): add tooltip to timepicker label (#12401)

* chore: change Datasource to Dataset in Explore ui (#12402)

* chore(explore):change dataset to datasource in ui

* modal

* Add space

* Changing it back🤦🏾‍♀️

* Chargeback

* fix: Refresh Interval Modal dropdown (#12406)

* fix(native-filters): incorrect queriesData state (#12409)

* refactor: from superset.utils.core break down date_parser (#12408)

* Fixes control panel fields styling (#12236) (#12326)

* feat: Resizable dataset and controls panels on Explore view (#12411)

* Implement resizable panels on explore view

* Optimize chart rendering while resizing

* Make dataset column narrower

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418)

* [12181] Fix artifacts while drag and dropping deck.gl charts.

* Run prettier

* bump superset-ui packages for rolling window change (#12426)

* chore: bump superset-ui deckgl plugin (#12466)

* fix: do not show vertical scrollbar for charts in dashboard (#12478)

* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for #11419

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* fix(dashboard): use datasource id from slice metadata (#12483)

* fix(timepicker): make pyparsing thread safe (#12489)

* fix: make pyparsing thread safe

* remove parenthesis for decorator

* fix (SQL Lab): disappearing results on tab switch (#12472)

* fix (SQL Lab): disappearing results on tab switch

* Remove state

* Fix test

* fix: import ZIP files that have been modified (#12425)

* fix: import ZIP files that have been modified

* Add unit test

* update changelog with rc2 entries

* fix: impose dataset ownership check on old API (#12491)

* fix: impose dataset ownership check on old API

* update UPDATING.md

* partially protect the old MVC also

* prevent metric and column add and update

* ci: remove refs/tags from docker tags on a release (#12518)

* ci: remove refs/tags from docker tags on a release

* wider head

* fix: lowercase all columns in examples (#12530)

* fix(explore): time table control panel (#12532)

* fix(explore): Add Time section back to FilterBox (#12537)

* Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536)

* fix: Select options overflowing Save chart modal on Explore view (#12522)

* Fix select options overflowing modal

* fix unit test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>

* Fix list filters vertical alignment (#12497)

* feat(db-engine): Add support for Apache Solr (#12403)

* [db engine] Add support for Apache Solr

* Fixing typo

* chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337)

* add rc3 changelog entries

* fix: Popover closes on change of dropdowns values (#12410)

* fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555)

* fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556)

* fix: height on grid results (#12558)

* fix: case expression should not have double quotes (#12562)

* Fix 500 error when loading dashboards with slice having deleted dataset (#12535)

* add rc4 changelog entries

* Fixed typo on line 348

* Added files

Co-authored-by: Daniel Gaspar <danielvazgaspar@gmail.com>
Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Junlin Chen <junlin@preset.io>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com>
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Grace Guo <grace.guo@airbnb.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Xiang Fu <fx19880617@gmail.com>
Co-authored-by: Ahmed Adel <github@aadel.io>
Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: Shuyao Bi <shuyaob@andrew.cmu.edu>
Co-authored-by: Lyndsi Kay Williams <lyndsikaywilliams@Lyndsis-MacBook-Pro.local>
@laxmanraparthi laxmanraparthi mentioned this issue Jun 28, 2023
Open
This was referenced Nov 26, 2023
Open
Open
Open
@m-ajay m-ajay mentioned this issue Nov 28, 2023
Open
This was referenced Dec 14, 2023
Open
Open
This was referenced Dec 20, 2023
Open
Open
@matrix-compute matrix-compute mentioned this issue Dec 26, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this issue Jan 2, 2024
Open
@matrix-compute matrix-compute mentioned this issue Feb 16, 2024
Open
@matrix-compute matrix-compute mentioned this issue Mar 11, 2024
Merged
@laxmanraparthi laxmanraparthi mentioned this issue Mar 15, 2024
Open
@matrix-compute matrix-compute mentioned this issue Mar 23, 2024
Open
This was referenced May 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkucharc kkucharc

Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkucharc @junlincc