Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Python dependencies in #11499 #12079

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Dec 16, 2020

SUMMARY

This PR fixes #11499 which requires Redis to be a core Python dependency for the AsyncQueryManager Flask extension.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI. Note the dependencies were updated via pip-compile-multi --no-upgrade.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@@ -17,4 +17,4 @@
# under the License.
-e file:.
pyrsistent>=0.16.1,<0.17
importlib-metadata>=1.7.0, <2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to resolve conflicting versions.

pydruid>=0.6.1,<0.7
pyhive[hive]>=0.6.1
tableschema
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ABC.

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nytai
Copy link
Member

nytai commented Dec 16, 2020

pip-compile-multi --no-upgrade -- oh, so that's how you add a dependency without upgrading every other one!

@@ -35,9 +35,9 @@ pyhive[hive,presto]==0.6.3 # via -r requirements/development.in, -r requirement
pylint==2.6.0 # via -r requirements/testing.in
pytest-cov==2.10.1 # via -r requirements/testing.in
pytest==6.1.2 # via -r requirements/testing.in, pytest-cov
redis==3.5.3 # via -r requirements/testing.in
Copy link
Member

@robdiciuccio robdiciuccio Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redis is currently required for running tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robdiciuccio this will be inherited from base.in.

@@ -10,7 +10,6 @@
gevent==20.9.0 # via -r requirements/docker.in
greenlet==0.4.17 # via gevent
psycopg2-binary==2.8.6 # via -r requirements/docker.in
redis==3.5.3 # via -r requirements/docker.in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is replaced by the requirement in base, yes?

@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #12079 (02647df) into master (148a001) will decrease coverage by 2.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12079      +/-   ##
==========================================
- Coverage   65.96%   63.44%   -2.52%     
==========================================
  Files         959      959              
  Lines       47160    47160              
  Branches     4613     4613              
==========================================
- Hits        31111    29923    -1188     
- Misses      15898    17053    +1155     
- Partials      151      184      +33     
Flag Coverage Δ
cypress ?
javascript 62.65% <ø> (-0.02%) ⬇️
python 63.92% <ø> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (-100.00%) ⬇️
...tend/src/dashboard/containers/DashboardBuilder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...c/visualizations/FilterBox/FilterBoxChartPlugin.js 0.00% <0.00%> (-100.00%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148a001...02647df. Read the comment docs.

@john-bodley john-bodley merged commit c306368 into apache:master Dec 16, 2020
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Dec 16, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
(cherry picked from commit c306368)
amitmiran137 pushed a commit to simcha90/incubator-superset that referenced this pull request Dec 18, 2020
* upstream/master: (55 commits)
  feat(explore): time picker enhancement (apache#11418)
  feat: update alert/report icons and column order (apache#12081)
  feat(explore): metrics and filters controls redesign (apache#12095)
  feat(alerts/reports): add refresh action (apache#12071)
  chore: add latest tag action (apache#11148)
  fix(reports): increase crontab size and alert fixes (apache#12056)
  Small typo fix in Athena connection docs (apache#12099)
  feat(queries): security perm simplification (apache#12072)
  feat(databases): security perm simplification (apache#12036)
  feat(dashboards): security permissions simplification (apache#12012)
  feat(logs): security permissions simplification (apache#12061)
  chore: Remove unused CodeModal (apache#11972)
  Fix typescript error (apache#12074)
  fix: handle context-dependent feature flags in CLI (apache#12088)
  fix: Fix "View in SQLLab" bug (apache#12086)
  feat(alert/report): add 'not null' condition option to modal (apache#12077)
  bumping superset ui to 15.18 and deckgl to 0.3.2 (apache#12078)
  fix: Python dependencies in apache#11499 (apache#12079)
  reset active tab on open (apache#12048)
  fix: improve import flow UI/UX (apache#12070)
  ...
@robdiciuccio robdiciuccio mentioned this pull request Mar 3, 2021
3 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants