Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: impose dataset ownership check on old API #12491

Merged
merged 4 commits into from
Jan 13, 2021
Merged

fix: impose dataset ownership check on old API #12491

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c0d674
fix: impose dataset ownership check on old API
dpgaspar Jan 13, 2021
0ae16bf
update UPDATING.md
dpgaspar Jan 13, 2021
e949170
partially protect the old MVC also
dpgaspar Jan 13, 2021
bc1cac1
prevent metric and column add and update
dpgaspar Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/commands/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class DeleteFailedError(CommandException):


class ForbiddenError(CommandException):
status = 500
status = 403
message = "Action is forbidden"


Expand Down
12 changes: 11 additions & 1 deletion superset/views/datasource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@

from superset import db
from superset.connectors.connector_registry import ConnectorRegistry
from superset.exceptions import SupersetException
from superset.datasets.commands.exceptions import DatasetForbiddenError
from superset.exceptions import SupersetException, SupersetSecurityException
from superset.typing import FlaskResponse
from superset.views.base import check_ownership

from .base import api, BaseSupersetView, handle_api_exception, json_error_response

Expand All @@ -52,6 +54,14 @@ def save(self) -> FlaskResponse:
orm_datasource.database_id = database_id

if "owners" in datasource_dict and orm_datasource.owner_class is not None:
# Check ownership
try:
check_ownership(orm_datasource)
except SupersetSecurityException:
return json_error_response(
f"{DatasetForbiddenError.message}", DatasetForbiddenError.status
)

datasource_dict["owners"] = (
db.session.query(orm_datasource.owner_class)
.filter(orm_datasource.owner_class.id.in_(datasource_dict["owners"]))
Expand Down