Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explore): remove unnecessary parameters from the explore url #17123

Merged
merged 2 commits into from
Oct 18, 2021
Merged

fix(explore): remove unnecessary parameters from the explore url #17123

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc5005
remove unnecessary parameters from the explore url
suddjian Oct 15, 2021
ee33688
refactor, test
suddjian Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,18 @@ export default class Chart extends React.Component {
});
};

getChartUrl = () => getExploreLongUrl(this.props.formData);
getChartUrl = () => {
const filters = this.props.formData?.extra_form_data?.filters;
// remove formData params that we don't need in the explore url
// this should be superseded by some sort of "exploration context" system
const formData = {
...this.props.formData,
extra_form_data: { filters },
native_filters: undefined,
geido marked this conversation as resolved.
Show resolved Hide resolved
dataMask: undefined,
};
return getExploreLongUrl(formData, null, false);
};

exportCSV(isFullCSV = false) {
this.props.logEvent(LOG_ACTIONS_EXPORT_CSV_DASHBOARD_CHART, {
Expand Down