Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: postpone timerange endpoint removal #19513

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Apr 4, 2022

SUMMARY

The PR #18936 that deprecated time range endpoints (breaking change for 2.0) included a migration that had to be changed into a NOOP for 1.5.0 (2001fb5), as there were critical migrations after that PR that needed to go into the LTS v1 branch. This changes the original migration to a NOOP and adds a new migration that performs the same operation. This will ensure that both users that are running master branch, and orgs that run official releases, will have had the same migration logic applied to their metadata.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro requested a review from a team as a code owner April 4, 2022 12:13
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #19513 (206e76d) into master (0de03c4) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 206e76d differs from pull request most recent head dd263ad. Consider uploading reports for the commit dd263ad to get more accurate results

@@            Coverage Diff             @@
##           master   #19513      +/-   ##
==========================================
- Coverage   66.59%   66.43%   -0.17%     
==========================================
  Files        1678     1678              
  Lines       64242    64242              
  Branches     6539     6539              
==========================================
- Hits        42784    42676     -108     
- Misses      19763    19871     +108     
  Partials     1695     1695              
Flag Coverage Δ
hive ?
mysql 81.90% <ø> (ø)
postgres 81.95% <ø> (ø)
presto ?
python 82.04% <ø> (-0.35%) ⬇️
sqlite 81.72% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.00% <0.00%> (-15.77%) ⬇️
superset/db_engine_specs/presto.py 83.60% <0.00%> (-5.40%) ⬇️
superset/connectors/sqla/models.py 88.10% <0.00%> (-1.21%) ⬇️
superset/initialization/__init__.py 91.28% <0.00%> (-0.35%) ⬇️
superset/db_engine_specs/base.py 88.00% <0.00%> (-0.34%) ⬇️
superset/models/core.py 88.80% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.71% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de03c4...dd263ad. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review April 4, 2022 13:43
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 1eef923 into apache:master Apr 5, 2022
@villebro villebro deleted the villebro/noop-endpoints branch April 5, 2022 07:10
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants